Add --publish: the one ingress control
Everything else in the file gates egress, which left an everyday request unanswered: the agent starts a dev server inside the sandbox and a human wants to look at it. This puts a listener on the host that forwards into the container, so a browser, curl or an API tester reaches the server the sandboxed process runs. `--publish [ADDR:]HOST:CONTAINER`, config `publish` and AISB_PUBLISH, repeatable, with the cost named in the flag: it is ingress, so whatever that server serves is reachable from the address it binds. The default address is 127.0.0.1 because a bare podman -p binds every interface (measured) -- a port committed in a repo config must not quietly be a port on the LAN. publish_addr changes the default machine-wide; a spec with a non-loopback address warns on every run. The grammar is smaller than podman's on purpose: one port per entry, no ranges, no /udp, no `*` -- this list is reviewed line by line, and typing 0.0.0.0 is the whole warning. An address means three parts, so `127.0.0.1:8000` is refused rather than guessed. No -p alias: that flag belongs to the harness (claude -p prints). Fail closed, as elsewhere: --net none cannot forward a port and podman discards the mapping while starting the container anyway, so "it ran" would mean "nothing is listening"; a host port already in use is named before the container starts, not after a build; pick_port() will not hand the gate a port this run publishes. The container is labelled with the ports it was given, and doctor reports them. Inside, publish_rules() accepts tcp on the published ports in the input chain and never the output one. Measured (docs/networking.md): pasta delivers the connection over loopback, so that rule counts 0 packets on the reference host; it is there for a host or a bridge network that delivers on the interface, and so that `nft list table inet aisb` answers "what can reach this container". The ports are validated again inside the entrypoint, because a ruleset is not somewhere to splice an unvalidated string. And the measurement that makes a configured preview look broken: a server bound to 127.0.0.1 inside answers inside and refuses the published port outside, so dev servers must bind 0.0.0.0 -- both skills say so in the change that writes the port. Tests. Unit: the grammar and every port list that looks right and is not, config/env/flag precedence and dedup, the canonical spec in --print-policy, the `# ingress:` header, the flags reaching the invocation before the image, egress enforcement byte-identical with a port open, which chain the rule lands in and that a non-numeric port never reaches nft as code. e2e (tests/e2e/13_publish.sh): one real container with enforce=nft where the host gets its 200 and the same run still refuses a domain outside the allowlist at 403, the server runs as uid 1000 with no capabilities so it cannot widen its own port, and the host listener is gone when the container exits. LLM-Generated: true
This commit is contained in:
@@ -128,8 +128,21 @@ devports="$(grep -rIhoE --include='vite.config.*' --include='next.config.*' --in
|
||||
'(--[Pp][Oo][Rr][Tt][[:space:]=]+[0-9]{4,5})|([Pp][Oo][Rr][Tt][[:space:]]*[=:][[:space:]]*"?[0-9]{4,5})' . 2>/dev/null \
|
||||
| grep -oE '[0-9]{4,5}$' | sort -u | tr '\n' ' ')"
|
||||
[[ -n "$devports" ]] && note "ports named in dev-server configs: $devports"
|
||||
note "outbound (sandbox -> a service on this machine) is grantable: 100.64.0.1:<port>."
|
||||
note "inbound (host -> a server the sandbox started) is dropped by the ruleset -- references/port-and-loopback.md"
|
||||
exposed="$(files_matching Dockerfile 'Dockerfile.*' | xargs -r grep -hoiE '^EXPOSE[[:space:]]+[0-9]+' 2>/dev/null \
|
||||
| grep -oE '[0-9]+' | sort -u | tr '\n' ' ')"
|
||||
[[ -n "$exposed" ]] && note "EXPOSEd in the Dockerfile: $exposed"
|
||||
# The address matters as much as the port: a dev server pinned to loopback answers nothing on a
|
||||
# published port, so quote the project's own setting back when it says 127.0.0.1.
|
||||
binds="$(grep -rIhoE --include='vite.config.*' --include='next.config.*' --include='webpack*.js' \
|
||||
--include='gunicorn*' --include='Procfile' --include='settings.py' --include='*.toml' \
|
||||
'(host|HOST|BIND|bind|--host|-b)[^0-9A-Za-z]{0,4}(0\.0\.0\.0|127\.0\.0\.1|\[::1\]|localhost)' . 2>/dev/null \
|
||||
| grep -oE '0\.0\.0\.0|127\.0\.0\.1|\[::1\]|localhost' | sort | tr '\n' ' ')"
|
||||
[[ -n "$binds" ]] && note "addresses the project's own config binds to: $binds"
|
||||
note "outbound (sandbox -> a service on this machine): allow = 100.64.0.1:<port>."
|
||||
note "inbound (host -> a server the sandbox runs): publish = <port> -- loopback unless an address"
|
||||
note " is written in the spec. The two are not interchangeable: publish is ingress, allow is egress."
|
||||
note " a published port only reaches a server listening on 0.0.0.0 inside (measured), so a config that"
|
||||
note " binds loopback above needs that said in the same change. references/port-and-loopback.md"
|
||||
|
||||
# --------------------------------------------------------------------------- environment names
|
||||
section "environment variable NAMES the project references (no values)"
|
||||
@@ -174,8 +187,9 @@ fi
|
||||
# --------------------------------------------------------------------------- existing policy
|
||||
section "existing policy"
|
||||
KV_KEYS="net harness workdir cpus memory pids tmpfs_size base_image node_version pi_version \
|
||||
base_ttl_days base_auto_update selinux home_cache gate_addr gate_port extra_args pi_config \
|
||||
pi_token_env pi_token_auto pi_agent_dir thinking agents agents_dir agents_dest allow env mount install label"
|
||||
base_ttl_days base_auto_update selinux home_cache gate_addr gate_port publish publish_addr extra_args \
|
||||
pi_config pi_token_env pi_token_auto pi_agent_dir thinking agents agents_dir agents_dest \
|
||||
allow env mount install label"
|
||||
for f in .ai-sandbox/config .ai-sandbox/allow; do
|
||||
[[ -r "$f" ]] && found "$f ($(wc -l < "$f") lines)" || note "$f: absent"
|
||||
done
|
||||
@@ -193,6 +207,23 @@ if [[ -r .ai-sandbox/config ]]; then
|
||||
fi
|
||||
if [[ "$k" == net && "$v" == full ]]; then warn "net = full in a committed config: that is an escape hatch, not a policy"; fi
|
||||
if [[ "$k" == extra_args ]]; then warn "extra_args in a committed config: the podman escape hatch -- it belongs on one command line"; fi
|
||||
if [[ "$k" == publish ]]; then
|
||||
case "$v" in
|
||||
*/*) warn "publish = $v has a protocol suffix: one port per entry, no /udp" ;;
|
||||
*-*) warn "publish = $v is a range: ai-sandbox takes one port per entry, so a reviewed line is never a block of ports" ;;
|
||||
\[*) note "publish = $v -- an ipv6 bind in brackets, then host:container" ;;
|
||||
*:*:*) note "publish = $v -- addr:host:container; anything not loopback is an open door and warns on every run" ;;
|
||||
*:*) note "publish = $v -- host port -> container port, bound to 127.0.0.1 (the default)" ;;
|
||||
*[!0-9]*) warn "publish = $v is not a port, host:container or addr:host:container -- ai-sandbox refuses it" ;;
|
||||
*) note "publish = $v -- 127.0.0.1:$v -> container $v; the server must bind 0.0.0.0 inside" ;;
|
||||
esac
|
||||
fi
|
||||
if [[ "$k" == publish_addr ]]; then
|
||||
case "$v" in
|
||||
127.*|localhost|::1|\[::1\]) note "publish_addr = $v -- loopback, the safe default" ;;
|
||||
*) warn "publish_addr = $v in a repo config widens every bare publish line in this directory -- the user's config, if anywhere" ;;
|
||||
esac
|
||||
fi
|
||||
done < .ai-sandbox/config
|
||||
fi
|
||||
if [[ -r .ai-sandbox/allow ]]; then
|
||||
@@ -225,7 +256,8 @@ else
|
||||
fi
|
||||
|
||||
section "next"
|
||||
note "1. decide net / allow / env / mount / install / limits from the above (SKILL.md step 2)"
|
||||
note "1. decide net / allow / env / mount / install / publish / limits from the above (SKILL.md step 2)"
|
||||
note "2. write .ai-sandbox/allow and .ai-sandbox/config, commented, names only"
|
||||
note "3. verify with ai-sandbox --print-policy and --dry-run (no build, no container, no network)"
|
||||
note "4. then one live probe per endpoint the project really needs"
|
||||
note "4. then one live probe per endpoint the project really needs -- and from the host too if you"
|
||||
note " wrote publish: that port exists only while a sandbox runs, and only 0.0.0.0 inside answers it"
|
||||
|
||||
Reference in New Issue
Block a user